Update references #3058
Merged
Update references #3058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
NNCF OpenVINO
|
@openvinotoolkit/nncf-maintainers, can someone review this, please. Thank you. |
KodiaqQ
commented
Nov 5, 2024
| @@ -1023,7 +1023,7 @@ def _create_ov_model(self, is_int8=False, with_multiply=False, n_layers=8): | |||
| alpha = np.array([1.5], dtype=np.float32) | |||
| alpha = opset.constant(alpha, dtype=np.float32) | |||
| lambda_value = np.array([1.5], dtype=np.float32) | |||
| lambda_value = opset.constant(alpha, dtype=np.float32) | |||
| lambda_value = opset.constant(lambda_value, dtype=np.float32) | |||
There was a problem hiding this comment.
@andreyanufr, could you comment please, was the lambda value replaced by alpha intentionally or by mistake? With the newest OV version, it causes the issue TypeError: The necessary overload for constant was not found
There was a problem hiding this comment.
It was mistake. I think we can use lambda_value = opset.constant(lambda_value, dtype=np.float32) or remove lambda_value = np.array([1.5], dtype=np.float32). Both changes are valid.
MaximProshin
approved these changes
Nov 5, 2024
andreyanufr
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Reason for changes
Related tickets
Tests