Make SE algorithm also return zero points #3054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
NNCF OpenVINO
|
No regressions on NNCF/job/manual/job/post_training_weight_compression/240 |
andreyanufr
reviewed
Nov 4, 2024
| @@ -358,6 +358,12 @@ def do_int_quantization( | |||
| """ | |||
| assert config.is_integer(), "The function supports integer quantization only" | |||
| group_size = config.group_size | |||
| is_asym = config.mode in [CompressWeightsMode.INT8_ASYM, CompressWeightsMode.INT4_ASYM] | |||
| if is_asym and (precomputed_scale is None) != (precomputed_zero_point is None): | |||
| raise ValueError( | |||
There was a problem hiding this comment.
Is it working with data free approach for INT4_ASYM?
There was a problem hiding this comment.
During data-free asymmetric compression, both precomputed_scale and precomputed_zero_point are None, so the if condition does not hold and the exception is not raised.
andreyanufr
approved these changes
Nov 6, 2024
ljaljushkin
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
do_int_quantizationfunction, made its signature more strict.Reason for changes
do_int_quantization. Avoid wrong usage of the function.Tests
Added a test to verify correctness of feeding precomputed quantization parameters to
do_int_quantization.Tickets
Prerequisite to 139047.