Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove warning from examples #3023

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Remove warning from examples #3023

merged 2 commits into from
Oct 21, 2024

Conversation

l-bat
Copy link
Collaborator

@l-bat l-bat commented Oct 17, 2024 •
edited
Loading

Changes

Add subset_size to PTQ samples after merging #2995 to remove the warning message
CI: https://github.com/openvinotoolkit/nncf/actions/runs/11436915496

@l-bat l-bat requested a review from alexsu52 October 17, 2024 13:50
@l-bat l-bat requested a review from a team as a code owner October 17, 2024 13:50
@github-actions github-actions bot added NNCF PT Pull requests that updates NNCF PyTorch NNCF OpenVINO Pull requests that updates NNCF OpenVINO NNCF ONNX Pull requests that updates NNCF ONNX labels Oct 17, 2024
@zina-cs
Copy link
Contributor

zina-cs commented Oct 17, 2024

.take

alexsu52
alexsu52 requested changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@alexsu52 alexsu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you take subset size from datasets instead of using magic constants if len is implemented for datasets?

@l-bat l-bat requested a review from alexsu52 October 18, 2024 09:18
@alexsu52 alexsu52 merged commit d33ce2f into openvinotoolkit:develop Oct 21, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexsu52 alexsu52 alexsu52 approved these changes

Assignees
No one assigned
Labels
NNCF ONNX Pull requests that updates NNCF ONNX NNCF OpenVINO Pull requests that updates NNCF OpenVINO NNCF PT Pull requests that updates NNCF PyTorch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@l-bat @zina-cs @alexsu52