Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Len checks for subset size test #2993

Closed
wants to merge 1 commit into from

Conversation

zina-cs
Copy link
Contributor

@zina-cs zina-cs commented Sep 26, 2024

…set has len implemented or not. @l-bat , awaiting your feedback, thank you.

Changes

Edited test method written by @awayzjj and added the Len tests

Reason for changes

Inconsistencies arise when the dataset size is less than the provided or default 'subset_size'.

Related tickets

Closes: #2562

Tests

WIP

…set has len implemented or not. @l-bat , awaiting your feedback, thank you.
@zina-cs zina-cs requested a review from a team as a code owner September 26, 2024 14:51
@github-actions github-actions bot added the NNCF OpenVINO Pull requests that updates NNCF OpenVINO label Sep 26, 2024
@l-bat
Copy link
Collaborator

l-bat commented Sep 26, 2024

Please take a look at #2769 (comment)
We just should display a warning during the statistics collection process if the provided dataset is shorter than subset_size

@alexsu52 alexsu52 requested a review from l-bat September 26, 2024 16:18
@l-bat
Copy link
Collaborator

l-bat commented Oct 9, 2024

The contributor opened another PR #2995 to address the issue.

@l-bat l-bat closed this Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NNCF OpenVINO Pull requests that updates NNCF OpenVINO
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Good First Issue][NNCF]: Dump actual_subset_size to ov.Model
2 participants