Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TorchFX][Conformance test] Migration to torch.export.export #2990

Merged
merged 1 commit into from
Sep 30, 2024
Merged

[TorchFX][Conformance test] Migration to torch.export.export #2990

merged 1 commit into from
Sep 30, 2024

Conversation

daniil-lyakhov
Copy link
Collaborator

@daniil-lyakhov daniil-lyakhov commented Sep 25, 2024 •
edited
Loading

Changes

  • tests/post_training/pipelines/image_classification_torchvision.py supports both capture_pre_autograd_model and torch.export.export(...).module() export paths
  • Micro fix in NNCFGraph

Reason for changes

  • capture_pre_autograd_graph introduces accuracy drop for the swin_v2_s model (Improvement: Metric value is better than reference 0.836 > 0.8296)
  • Incorrect constant collection fails on models exported via torch.export.export(...).module()

Related tickets

#2766

Tests

post_training_quantization/490/

@github-actions github-actions bot added NNCF PT Pull requests that updates NNCF PyTorch experimental NNCF OpenVINO Pull requests that updates NNCF OpenVINO NNCF ONNX Pull requests that updates NNCF ONNX NNCF PTQ Pull requests that updates NNCF PTQ labels Sep 25, 2024
@daniil-lyakhov daniil-lyakhov changed the title Dl/fx/switch capture to export [TorchFX][Conformance test] Migration to torch.export.export Sep 25, 2024
@daniil-lyakhov daniil-lyakhov mentioned this pull request Sep 25, 2024
Closed
1 task
@daniil-lyakhov daniil-lyakhov force-pushed the dl/fx/switch_capture_to_export branch 2 times, most recently from 8de4526 to b300aa2 Compare September 30, 2024 08:23
@github-actions github-actions bot removed NNCF PT Pull requests that updates NNCF PyTorch NNCF OpenVINO Pull requests that updates NNCF OpenVINO NNCF ONNX Pull requests that updates NNCF ONNX labels Sep 30, 2024
@daniil-lyakhov daniil-lyakhov marked this pull request as ready for review September 30, 2024 08:23
@daniil-lyakhov daniil-lyakhov requested a review from a team as a code owner September 30, 2024 08:23
@alexsu52 alexsu52 merged commit ad11ee1 into openvinotoolkit:develop Sep 30, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexsu52 alexsu52 alexsu52 approved these changes

Assignees
No one assigned
Labels
experimental NNCF PTQ Pull requests that updates NNCF PTQ
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daniil-lyakhov @alexsu52