Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix track context manager #2915

Conversation

nikita-savelyevv
Copy link
Collaborator

@nikita-savelyevv nikita-savelyevv commented Aug 26, 2024

Changes

Fix track usage as a context manager. This is a regression after #2892.

@nikita-savelyevv nikita-savelyevv requested a review from a team as a code owner August 26, 2024 14:24
@github-actions github-actions bot added the NNCF Common Pull request that updates NNCF Common label Aug 26, 2024
@AlexanderDokuchaev
Copy link
Collaborator

@nikita-savelyevv What regression? And why is it not cached by tests?

@nikita-savelyevv
Copy link
Collaborator Author

What regression?

There will be an error if track is used as a context manager:

Failed: 'Progress' object has no attribute 'progress'

And why is it not cached by tests?

There are no tests for the progress tracker. I've added them now.

@nikita-savelyevv
Copy link
Collaborator Author

The issue was caught in PTQ conformance test. Build 458 with the fix has passed

@AlexanderDokuchaev AlexanderDokuchaev self-assigned this Aug 26, 2024
@AlexanderDokuchaev AlexanderDokuchaev merged commit 3a9304c into openvinotoolkit:develop Aug 26, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NNCF Common Pull request that updates NNCF Common
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants