[GA] Add Set api label action
#2900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KodiaqQ
approved these changes
Aug 22, 2024
AlexanderDokuchaev
added a commit
to AlexanderDokuchaev/nncf
that referenced
this pull request
Aug 23, 2024
### Changes Add "Set api label" action Workflow to update API label: 1) `api_changes_check.yml` runs (build docs, compare with develop) and saves artifacts with status of check 'add, remove or none` (for external contributor only after approval) 2) After finished job will be triggered `api_set_label.yml` with write permission to update label from `api_changes_check.yml`, that downloads artifact and updates API label in pull request ### Reason for changes To follow [Good practices for mitigating script injection attacks](https://docs.github.com/en/actions/security-for-github-actions/security-guides/security-hardening-for-github-actions#good-practices-for-mitigating-script-injection-attacks) pull_request_target is not allow to use for api_changes_check.yml. But pull_request provide only read permission in result not possible to add label to PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add "Set api label" action
Workflow to update API label:
api_changes_check.ymlruns (build docs, compare with develop) and saves artifacts with status of check 'add, remove or none` (for external contributor only after approval)api_set_label.ymlwith write permission to update label fromapi_changes_check.yml, that downloads artifact and updates API label in pull requestReason for changes
To follow Good practices for mitigating script injection attacks pull_request_target is not allow to use for api_changes_check.yml.
But pull_request provide only read permission in result not possible to add label to PR.