Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OpenVINO] Add Slice metatype #2847

Merged
merged 2 commits into from
Jul 31, 2024
Merged

Conversation

kshpv
Copy link
Collaborator

@kshpv kshpv commented Jul 29, 2024

Changes

Adds Slice operation - https://docs.openvino.ai/2022.3/openvino_docs_ops_movement_Slice_8.html
As a result the performance for modnet_webcam_portrait_matting from DLB was improved (local measurement)
from 44 FPS till 72 FPS.
image

Reason for changes

Fix incorrect quantization scheme due to unknown metatype

Related tickets

144218

Tests

Manually

@kshpv kshpv requested a review from a team as a code owner July 29, 2024 09:31
@github-actions github-actions bot added the NNCF OpenVINO Pull requests that updates NNCF OpenVINO label Jul 29, 2024
@kshpv kshpv requested a review from alexsu52 July 29, 2024 09:32
Copy link
Contributor

@alexsu52 alexsu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kshpv
Copy link
Collaborator Author

kshpv commented Jul 30, 2024

ptq build - 437

@KodiaqQ
Copy link
Collaborator

KodiaqQ commented Jul 30, 2024

Don't we need to align nncf/common/hardware/configs/cpu.json and other schemes also?

@alexsu52 alexsu52 requested a review from KodiaqQ July 30, 2024 15:10
@kshpv
Copy link
Collaborator Author

kshpv commented Jul 31, 2024

ptq build - 437

build is passed

@kshpv
Copy link
Collaborator Author

kshpv commented Jul 31, 2024

Don't we need to align nncf/common/hardware/configs/cpu.json and other schemes also?

I am not sure how to make this alignment. Could you clarify?

@KodiaqQ
Copy link
Collaborator

KodiaqQ commented Jul 31, 2024

I am not sure how to make this alignment. Could you clarify?

Our schemes from the nncf/common/hardware/configs are the basement for the quantization. Other NNCF parts (like metatypes) should be aligned with them, not vice-versa. For now, I don't see the Slice operation in nncf/common/hardware/configs/cpu.json.

@KodiaqQ
Copy link
Collaborator

KodiaqQ commented Jul 31, 2024

build is passed

Are there any models in our conformance run that contain Slice operation?

@github-actions github-actions bot added the NNCF Common Pull request that updates NNCF Common label Jul 31, 2024
@kshpv
Copy link
Collaborator Author

kshpv commented Jul 31, 2024

build is passed

Are there any models in our conformance run that contain Slice operation?

I am not sure how to make this alignment. Could you clarify?

Our schemes from the nncf/common/hardware/configs are the basement for the quantization. Other NNCF parts (like metatypes) should be aligned with them, not vice-versa. For now, I don't see the Slice operation in nncf/common/hardware/configs/cpu.json.

HWConfigOpName was added for Slice op and added to hw configs as well.

@kshpv
Copy link
Collaborator Author

kshpv commented Jul 31, 2024

build is passed

Are there any models in our conformance run that contain Slice operation?

I did not check that, but all models passed

@KodiaqQ
Copy link
Collaborator

KodiaqQ commented Jul 31, 2024

I did not check that, but all models passed

Why did you run this test then? What should it show?

@kshpv
Copy link
Collaborator Author

kshpv commented Jul 31, 2024

I did not check that, but all models passed

Why did you run this test then? What should it show?

To be sure that there is no regression on PTQ scope it was asked by other reviewer

@kshpv kshpv added NNCF Common Pull request that updates NNCF Common and removed NNCF Common Pull request that updates NNCF Common labels Jul 31, 2024
@KodiaqQ KodiaqQ merged commit f5aa90f into openvinotoolkit:develop Jul 31, 2024
12 checks passed
KodiaqQ added a commit that referenced this pull request Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NNCF Common Pull request that updates NNCF Common NNCF OpenVINO Pull requests that updates NNCF OpenVINO
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants