Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect scales in SmoothQuant algo #2830

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Fix incorrect scales in SmoothQuant algo #2830

merged 1 commit into from
Jul 23, 2024

Conversation

l-bat
Copy link
Collaborator

@l-bat l-bat commented Jul 22, 2024

Changes

Incorrect processing of

nncf/nncf/quantization/algorithms/smooth_quant/algorithm.py

Lines 141 to 143 in 49e9820

if ratio > best_ratio:
best_ratio = ratio
best_scale = deepcopy(scales)

Reason for changes

  • To avoid error: operands could not be broadcast together with shapes, when we try to apply scales from previous group to node. SQ should be ignored for such nodes with an appropriate message: DEBUG:nncf:Skipped SmoothQuant for nodes after <node_name> because of the empty scale.

Related tickets

  • 147043

Tests

@l-bat l-bat requested a review from KodiaqQ July 22, 2024 11:30
@l-bat l-bat requested a review from a team as a code owner July 22, 2024 11:30
@github-actions github-actions bot added documentation Improvements or additions to documentation NNCF PTQ Pull requests that updates NNCF PTQ labels Jul 22, 2024
@KodiaqQ KodiaqQ merged commit f1df8c9 into openvinotoolkit:develop Jul 23, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KodiaqQ KodiaqQ KodiaqQ approved these changes

Assignees

@KodiaqQ KodiaqQ

Labels
documentation Improvements or additions to documentation NNCF PTQ Pull requests that updates NNCF PTQ
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@l-bat @KodiaqQ