Increase approx abs #2826
Merged
Increase approx abs #2826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
precommit/job/ubuntu20_precommit_pytorch/6653/ |
ljaljushkin
requested changes
Jul 19, 2024
KodiaqQ
reviewed
Jul 22, 2024
ljaljushkin
approved these changes
Jul 22, 2024
AlexanderDokuchaev
added a commit
to AlexanderDokuchaev/nncf
that referenced
this pull request
Jul 22, 2024
### Changes Increase abs from 1e-2 to 3e-2 ### Reason for changes Size of pruned and not prunned IR models can changes by openvino version. it's not first time when reference size required to be change, so increase threshold to be more tolerance. ``` 2024.2 desc0 pruned_file_bytes=596 not_pruned_file_bytes=932 desc1 pruned_file_bytes=1004 not_pruned_file_bytes=1340 desc2 pruned_file_bytes=2552 not_pruned_file_bytes=2756 desc3 pruned_file_bytes=584 not_pruned_file_bytes=872 desc4 pruned_file_bytes=748 not_pruned_file_bytes=940 desc5 pruned_file_bytes=1156 not_pruned_file_bytes=1900 desc6 pruned_file_bytes=1240 not_pruned_file_bytes=1900 desc7 pruned_file_bytes=620 not_pruned_file_bytes=956 2024.3 desc0 pruned_file_bytes=604 not_pruned_file_bytes=940 desc1 pruned_file_bytes=1004 not_pruned_file_bytes=1340 desc2 pruned_file_bytes=2552 not_pruned_file_bytes=2756 desc3 pruned_file_bytes=584 not_pruned_file_bytes=872 desc4 pruned_file_bytes=748 not_pruned_file_bytes=940 desc5 pruned_file_bytes=1228 not_pruned_file_bytes=1972 desc6 pruned_file_bytes=1312 not_pruned_file_bytes=1972 desc7 pruned_file_bytes=620 not_pruned_file_bytes=956 ``` ### Tests sparsity.movement.test_model_saving.TestONNXExport.test_ngraph_pruning sparsity.movement.test_model_saving.TestONNXExport.test_ngraph_pruning
KodiaqQ
added a commit
that referenced
this pull request
Jul 23, 2024
### Changes Increase abs from 1e-2 to 3e-2 ### Reason for changes Size of pruned and not prunned IR models can changes by openvino version. it's not first time when reference size required to be change, so increase threshold to be more tolerance. ``` 2024.2 desc0 pruned_file_bytes=596 not_pruned_file_bytes=932 desc1 pruned_file_bytes=1004 not_pruned_file_bytes=1340 desc2 pruned_file_bytes=2552 not_pruned_file_bytes=2756 desc3 pruned_file_bytes=584 not_pruned_file_bytes=872 desc4 pruned_file_bytes=748 not_pruned_file_bytes=940 desc5 pruned_file_bytes=1156 not_pruned_file_bytes=1900 desc6 pruned_file_bytes=1240 not_pruned_file_bytes=1900 desc7 pruned_file_bytes=620 not_pruned_file_bytes=956 2024.3 desc0 pruned_file_bytes=604 not_pruned_file_bytes=940 desc1 pruned_file_bytes=1004 not_pruned_file_bytes=1340 desc2 pruned_file_bytes=2552 not_pruned_file_bytes=2756 desc3 pruned_file_bytes=584 not_pruned_file_bytes=872 desc4 pruned_file_bytes=748 not_pruned_file_bytes=940 desc5 pruned_file_bytes=1228 not_pruned_file_bytes=1972 desc6 pruned_file_bytes=1312 not_pruned_file_bytes=1972 desc7 pruned_file_bytes=620 not_pruned_file_bytes=956 ``` ### Tests sparsity.movement.test_model_saving.TestONNXExport.test_ngraph_pruning Co-authored-by: Nikita Malinin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Increase abs from 1e-2 to 3e-2
Reason for changes
Size of pruned and not prunned IR models can changes by openvino version.
it's not first time when reference size required to be change, so increase threshold to be more tolerance.
Tests
sparsity.movement.test_model_saving.TestONNXExport.test_ngraph_pruning
sparsity.movement.test_model_saving.TestONNXExport.test_ngraph_pruning