Fix pass to remove ShapeOf subgraph #2820
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrey-churkin
force-pushed
the
ac/fix_shapeof_pass
branch
from
cd23a93 to
e113ac9
Compare
github-actions
bot
added
NNCF PT
|
Implemented here #2902 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
It is possible to remove a node in the Shape Of subgraph only if all output edges have an integer dtype. An additional condition has been added to check for this.
Reason for changes
In the picture below, integer edges are colored blue, and float edges are colored black. Nodes with a red border are removed during the ShapeOf removal pass, but they shouldn't be.
Related tickets
Ref: 146088
Tests
TODO