Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TorchFX] Graph/metatypes tests implementation #2796

Merged
merged 9 commits into from
Jul 30, 2024
Merged

[TorchFX] Graph/metatypes tests implementation #2796

merged 9 commits into from
Jul 30, 2024

Conversation

anzr299
Copy link
Contributor

@anzr299 anzr299 commented Jul 8, 2024 •
edited
Loading

Changes

  1. Added pytest to check if all the ops in the generated graph for resnet18, mobilenet_v3_small, vit_b_16, swin_v2_s and yolov8n models have valid metatypes in NNCF
  2. Added pytest to check if the generated NNCF graph for resnet18, mobilenet_v3_small, vit_b_16, swin_v2_s and yolov8n match with reference graphs. (tests/torch/fx/test_models.py)
  3. Add metatype mapping for the following:
  • linalg_vector_norm
  • clamp
  • clamp_min
  • hardswish_
  • dropout_

Reason for changes

Check if all model ops are supported by NNCF metatypes

Related tickets

#2778

Tests

New test file test_models.py added in tests/torch/fx/test_models.py

@anzr299 anzr299 requested a review from a team as a code owner July 8, 2024 12:47
@github-actions github-actions bot added NNCF PT Pull requests that updates NNCF PyTorch NNCF Common Pull request that updates NNCF Common experimental NNCF PTQ Pull requests that updates NNCF PTQ labels Jul 8, 2024
alexsu52
alexsu52 reviewed Jul 9, 2024
View reviewed changes
tests/torch/fx/test_models.py Outdated Show resolved Hide resolved
tests/torch/fx/test_models.py Outdated Show resolved Hide resolved
@daniil-lyakhov daniil-lyakhov changed the title Test ResNet Ops Support [TorchFX] Graph/metatypes tests implementation Jul 12, 2024
daniil-lyakhov
daniil-lyakhov requested changes Jul 13, 2024
View reviewed changes
tests/torch/fx/test_models.py Outdated Show resolved Hide resolved
tests/torch/fx/test_models.py Outdated Show resolved Hide resolved
tests/torch/fx/test_models.py Outdated Show resolved Hide resolved
tests/torch/fx/test_models.py Outdated Show resolved Hide resolved
tests/torch/fx/test_models.py Outdated Show resolved Hide resolved
tests/torch/requirements.txt Outdated Show resolved Hide resolved
tests/torch/fx/test_models.py Outdated Show resolved Hide resolved
tests/torch/fx/test_models.py Outdated Show resolved Hide resolved
@anzr299 anzr299 requested a review from daniil-lyakhov July 22, 2024 14:45
alexsu52
alexsu52 approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@alexsu52 alexsu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@daniil-lyakhov
Copy link
Collaborator

@anzr299, please rebase your changes

@anzr299 anzr299 closed this Jul 26, 2024
@anzr299 anzr299 reopened this Jul 26, 2024
@github-actions github-actions bot removed NNCF Common Pull request that updates NNCF Common experimental NNCF PTQ Pull requests that updates NNCF PTQ labels Jul 26, 2024
@anzr299
Copy link
Contributor Author

anzr299 commented Jul 26, 2024

@anzr299, please rebase your changes

Done

@alexsu52 alexsu52 merged commit 25eff06 into openvinotoolkit:develop Jul 30, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexsu52 alexsu52 alexsu52 approved these changes

@daniil-lyakhov daniil-lyakhov daniil-lyakhov approved these changes

@AlexanderDokuchaev AlexanderDokuchaev Awaiting requested review from AlexanderDokuchaev

Assignees

@daniil-lyakhov daniil-lyakhov

Labels
NNCF PT Pull requests that updates NNCF PyTorch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anzr299 @daniil-lyakhov @alexsu52