-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make NNCF common utils code pass mypy checks #2780
Conversation
… history dictionary keys and values.
Mypy and precommit jobs are red, please deal with it |
I have fixed the issues, it seemed to be import related and I used tuple instead of Typing.tuple by mistake |
I will explore the failed tests and what went wrong and try to fix it. |
I believe the failing test is due to the fact that I added an extra line in nncf/common/utils/timer.py. This causes a failed test tests/common/test_timer.py because of the line |
Please update the reference here. It is OK practice to update reference files when the new reference is checked manually and is confirmed to be correct |
Hi @daniil-lyakhov, can you please review the changes. I believe all the checks have passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use typing.Any
instead of object
in typehints. Besides that the pr is ready to go
Alright, I will replace all the |
@AlexanderDokuchaev, please merge |
Changes
Made all the mypy checks pass for nncf/common/utils
Related tickets
Closes Issue #2491