[Experimental] TorchFX PTQ backend #2764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
NNCF PT
daniil-lyakhov
force-pushed
the
dl/torch_fx_quantization_init
branch
2 times, most recently
from
fbd0fd5 to
cea1693
Compare
daniil-lyakhov
changed the title
daniil-lyakhov
force-pushed
the
dl/torch_fx_quantization_init
branch
4 times, most recently
from
3fb62df to
c818a93
Compare
alexsu52
reviewed
Jun 27, 2024
There was a problem hiding this comment.
It is curious that the developer does not quantize any operations in the torch.fx.GraphModule, but at the same time does not report errors that the torch backend does not support Torch FX.
Taking account that torch.fx is a part of torch and requires specific processing, I would like to make the following proposal:
- I agree to introduce TORCH_FX = "TorchFX" backend to simplify the factory code, but to simplify this PR you can skip adding support in nncf.quantize(). If you are going to do it you must warn the user that experimental code will be used.
- Make torch_fx as part of torch module. I mean nncf/experimental/torch_fx/ -> nncf/experimental/torch/fx/
- I suggest to use Torch GAs for TorchFX because requirements are the same and the backend is a part of Torch. In the future we may separate them, but only if we have problems with test completion times.
daniil-lyakhov
force-pushed
the
dl/torch_fx_quantization_init
branch
from
703dfde to
4d9ef0d
Compare
daniil-lyakhov
force-pushed
the
dl/torch_fx_quantization_init
branch
from
4d9ef0d to
2d5a02b
Compare
daniil-lyakhov
force-pushed
the
dl/torch_fx_quantization_init
branch
2 times, most recently
from
e48d097 to
71b49f7
Compare
This was referenced Jul 1, 2024
alexsu52
reviewed
Jul 2, 2024
daniil-lyakhov
commented
Jul 2, 2024
daniil-lyakhov
commented
Jul 2, 2024
alexsu52
reviewed
Jul 23, 2024
alexsu52
reviewed
Jul 23, 2024
daniil-lyakhov
force-pushed
the
dl/torch_fx_quantization_init
branch
from
444cb64 to
20a4eda
Compare
anzr299
reviewed
Jul 23, 2024
anzr299
reviewed
Jul 23, 2024
daniil-lyakhov
force-pushed
the
dl/torch_fx_quantization_init
branch
2 times, most recently
from
c166088 to
1eabd17
Compare
daniil-lyakhov
changed the title
daniil-lyakhov
force-pushed
the
dl/torch_fx_quantization_init
branch
from
b6bd3fc to
3064753
Compare
anzr299
approved these changes
Jul 25, 2024
daniil-lyakhov
force-pushed
the
dl/torch_fx_quantization_init
branch
from
3064753 to
826fed9
Compare
AlexanderDokuchaev
requested changes
Jul 25, 2024
nncf/quantization/algorithms/fast_bias_correction/torch_fx_backend.py
Outdated
Show resolved
Hide resolved
daniil-lyakhov
force-pushed
the
dl/torch_fx_quantization_init
branch
from
99b4344 to
3b4a992
Compare
AlexanderDokuchaev
approved these changes
Jul 26, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Reason for changes
To begin the Torch FX backend development
Related tickets
141640
#2766
Tests