Fix torch operator unpatching #2719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikita-savelyevv
commented
Jun 4, 2024
| @@ -80,14 +80,24 @@ def test_jit_script_exception_preserves_patching_isolated(): | |||
|
|
|||
|
|
|||
| def compile_and_run_test_model() -> torch.Tensor: | |||
| from tests.torch.helpers import BasicConvTestModel | |||
There was a problem hiding this comment.
Had to drop BasicConvTestModel because during its import nncf.torch is imported which is not acceptable for this specific test
alexsu52
reviewed
Jun 5, 2024
|
torch nightly build 256 is green |
AlexanderDokuchaev
approved these changes
Jun 11, 2024
AlexanderDokuchaev
pushed a commit
that referenced
this pull request
Aug 30, 2024
### Changes Check whether model is compiled based on `"_torchdynamo_orig_callable"` property of the model forward. ### Reason for changes `torch.compile` can be applied not only to the model itself, but to `forward()` method only. For example: ``` model.forward = torch.compile(model.forward) ``` In this case the model itself doesn't change and it won't be an instance of `torch._dynamo.OptimizedModule`. ### Related tickets 143796 ### Tests Added test when `torch.compile` is applied this way. It does not fail without the fix though, because the issue is sporadic. ### Relates to #2665, #2719
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
nncf.torch)Reason for changes
Fix inference of compiled torch models when
nncf.torchis importedRelated tickets
140265
Tests
Added
test_operator_unpatching