Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API][Torch] Save/Load transformations #2659

Merged

Conversation

daniil-lyakhov
Copy link
Collaborator

@daniil-lyakhov daniil-lyakhov commented Apr 26, 2024

Changes

model.nncf.get_config method and nncf.torch.load_from_config function are presented

Reason for changes

To enable saving/loading NNCFNetwork transformations

Related tickets

129586

Tests

tests/torch/test_serialization.py is updated

@github-actions github-actions bot added NNCF PT Pull requests that updates NNCF PyTorch NNCF PTQ Pull requests that updates NNCF PTQ labels Apr 26, 2024
@daniil-lyakhov daniil-lyakhov changed the title Dl/torch/nncf config api [Torch] Save/Load transformations API Apr 26, 2024
@daniil-lyakhov daniil-lyakhov force-pushed the dl/torch/nncf_config_api branch from 297f136 to f8811da Compare May 6, 2024 12:22
@github-actions github-actions bot removed the NNCF PTQ Pull requests that updates NNCF PTQ label May 6, 2024
@daniil-lyakhov daniil-lyakhov marked this pull request as ready for review May 6, 2024 12:24
@daniil-lyakhov daniil-lyakhov requested a review from a team as a code owner May 6, 2024 12:24
@daniil-lyakhov daniil-lyakhov changed the title [Torch] Save/Load transformations API [API][Torch] Save/Load transformations May 6, 2024
Copy link

codecov bot commented May 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 29.86%. Comparing base (d507585) to head (f8811da).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #2659       +/-   ##
============================================
- Coverage    89.25%   29.86%   -59.39%     
============================================
  Files          495      495               
  Lines        48085    45986     -2099     
============================================
- Hits         42917    13735    -29182     
- Misses        5168    32251    +27083     
Files Coverage Δ
nncf/torch/__init__.py 0.00% <0.00%> (-89.48%) ⬇️
nncf/torch/model_creation.py 0.00% <0.00%> (-88.14%) ⬇️
nncf/torch/nncf_network.py 0.00% <0.00%> (-83.36%) ⬇️

... and 332 files with indirect coverage changes

Flag Coverage Δ
COMMON ?
ONNX ?
OPENVINO ?
TENSORFLOW 29.86% <0.00%> (-0.02%) ⬇️
TORCH ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
common 76.35% <ø> (-17.42%) ⬇️
torch 0.01% <0.00%> (-90.46%) ⬇️
tensorflow 93.74% <ø> (+1.00%) ⬆️
onnx 0.00% <ø> (-87.06%) ⬇️
openvino 0.00% <ø> (-90.09%) ⬇️
ptq 15.19% <ø> (-68.93%) ⬇️

Copy link
Contributor

@alexsu52 alexsu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexsu52 alexsu52 merged commit 8275d57 into openvinotoolkit:develop May 14, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NNCF PT Pull requests that updates NNCF PyTorch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants