#2570 Issue: Update config.py #2597
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2597 +/- ##
===========================================
- Coverage 91.16% 83.56% -7.61%
===========================================
Files 494 494
Lines 45350 45374 +24
===========================================
- Hits 41342 37915 -3427
- Misses 4008 7459 +3451
... and 81 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ljaljushkin
requested changes
Mar 25, 2024
| @@ -127,13 +128,17 @@ def _is_path_to_algorithm_name(path_parts: List[str]) -> bool: | |||
| def validate(loaded_json): | |||
| try: | |||
| jsonschema.validate(loaded_json, NNCFConfig.schema()) | |||
|
|
|||
| except JsonSchemaValidationError as e: | |||
| logger.error('Invalid NNCF config supplied!') | |||
There was a problem hiding this comment.
Why do you need this error handler? Isn't it the same as the next one? Shouldn't the next one executed?
|
Due to the lack of activity @LalitSP was unassigned from the issue and PR is closed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Updated the validation logic in the config.py file to handle errors related to additional properties not defined in the schema. Added checks to raise a more informative ValidationError when unexpected properties are encountered during validation.
Reason for changes
The current error reporting mechanism in the JSON schema validation is misleading, especially when encountering unexpected properties in the configuration.
Related tickets
Ticket ID: 94933
Tests
test $pytest tests/torch/test_config_schema.py -sv -k 'bug_in_error_report'