-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use tabulate instead of texttable #2574
Use tabulate instead of texttable #2574
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2574 +/- ##
===========================================
- Coverage 90.89% 84.54% -6.35%
===========================================
Files 492 492
Lines 45101 45096 -5
===========================================
- Hits 40995 38128 -2867
- Misses 4106 6968 +2862
... and 56 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add screenshots before/after?
Example of tables:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Changes
Using tabulate instead of texttable package to create tables.
Reason for changes
Avoid installation two packages to same task.
Tabulate is optional dependencies of pandas package, that used in NNCF. #2542
Related tickets
134603