-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PT] Extractor for fused convolution #2559
[PT] Extractor for fused convolution #2559
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2559 +/- ##
===========================================
- Coverage 90.92% 84.84% -6.08%
===========================================
Files 498 494 -4
Lines 45550 45332 -218
===========================================
- Hits 41415 38464 -2951
- Misses 4135 6868 +2733
... and 83 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
d09271a
to
b9de496
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, please address my comments
51ed46a
to
c3cbc0d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, provide e2e results for PyTorch backend.
@alexsu52 TriggerBetta/647 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Changes
conv
,batch_norm
,group_norm
andlinear
functions.conv
andbatch norm
modules.model_graph_manager
module to works with models with wrapped withtrace_parameters=True
. (model_analizer.py will be deprecated after finished refactor PTQ to use graph with constant nodes)Related tickets
129581
Tests
tests/torch/test_model_graph_manager.py
tests/torch/test_extractor.py