Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check on None #2558

Merged
merged 3 commits into from
Mar 8, 2024
Merged

Add check on None #2558

merged 3 commits into from
Mar 8, 2024

Conversation

kshpv
Copy link
Collaborator

@kshpv kshpv commented Mar 7, 2024

Changes

Add a check on None for OverflowFix parameter.

Reason for changes

Fix bug

Related tickets

N/A

Tests

Add test on a failed before scenario

@kshpv kshpv requested a review from a team as a code owner March 7, 2024 16:24
@github-actions github-actions bot added the NNCF PTQ Pull requests that updates NNCF PTQ label Mar 7, 2024
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.55%. Comparing base (7f0c73c) to head (2f11032).
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2558      +/-   ##
===========================================
+ Coverage    77.95%   84.55%   +6.60%     
===========================================
  Files          498      498              
  Lines        45553    45621      +68     
===========================================
+ Hits         35511    38576    +3065     
+ Misses       10042     7045    -2997     
Files Coverage Δ
nncf/quantization/advanced_parameters.py 85.62% <100.00%> (ø)

... and 68 files with indirect coverage changes

Flag Coverage Δ
COMMON 42.73% <0.00%> (?)
ONNX 34.77% <0.00%> (?)
OPENVINO ∅ <ø> (?)
TENSORFLOW 29.59% <100.00%> (ø)
TORCH 66.00% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
common 93.10% <ø> (+4.77%) ⬆️
torch 93.43% <ø> (+0.01%) ⬆️
tensorflow 93.72% <ø> (ø)
onnx 93.05% <ø> (+93.05%) ⬆️
openvino 25.58% <ø> (ø)
ptq 67.31% <100.00%> (+14.31%) ⬆️

@kshpv kshpv requested a review from KodiaqQ March 7, 2024 16:30
@github-actions github-actions bot added the NNCF TF Pull requests that updates NNCF TensorFlow label Mar 7, 2024
@kshpv kshpv requested a review from KodiaqQ March 7, 2024 16:59
@KodiaqQ KodiaqQ merged commit edd397b into openvinotoolkit:develop Mar 8, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NNCF PTQ Pull requests that updates NNCF PTQ NNCF TF Pull requests that updates NNCF TensorFlow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants