Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop binarization algorithm support #2556

Merged

Conversation

KodiaqQ
Copy link
Collaborator

@KodiaqQ KodiaqQ commented Mar 7, 2024

Changes

  • Dropped binarization algorithm support (as deprecated before);

Reason for changes

  • Actual state of the algorithms list;

Related tickets

  • 133129

Tests

  • install_pt_gpu/404/ - passed
  • install_pt_cpu/398/ - passed
  • TriggerBetta/634/ - passed
  • torch_nightly/154/ - passed
  • ubuntu20_precommit_pytorch/6198/ - passed

@github-actions github-actions bot added documentation Improvements or additions to documentation NNCF TF Pull requests that updates NNCF TensorFlow NNCF PT Pull requests that updates NNCF PyTorch NNCF Common Pull request that updates NNCF Common labels Mar 7, 2024
@openvino-nncf-ci openvino-nncf-ci added the API Public API-impacting changes label Mar 7, 2024
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.54%. Comparing base (09960b9) to head (74345c2).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2556      +/-   ##
===========================================
- Coverage    90.89%   84.54%   -6.35%     
===========================================
  Files          498      492       -6     
  Lines        45553    45103     -450     
===========================================
- Hits         41405    38132    -3273     
- Misses        4148     6971    +2823     
Files Coverage Δ
nncf/common/statistics.py 95.12% <ø> (+1.94%) ⬆️
nncf/config/definitions.py 100.00% <ø> (ø)
nncf/config/schema.py 65.38% <ø> (-1.29%) ⬇️
nncf/config/schemata/defaults.py 100.00% <ø> (ø)
nncf/torch/__init__.py 87.17% <ø> (-0.33%) ⬇️

... and 57 files with indirect coverage changes

Flag Coverage Δ
COMMON 42.76% <ø> (+0.03%) ⬆️
ONNX 34.65% <ø> (-0.12%) ⬇️
OPENVINO ∅ <ø> (∅)
TENSORFLOW 29.86% <ø> (+0.27%) ⬆️
TORCH 65.76% <ø> (-0.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
common 93.11% <ø> (-0.65%) ⬇️
torch 93.58% <ø> (+0.15%) ⬆️
tensorflow 93.72% <ø> (ø)
onnx 93.05% <ø> (ø)
openvino 25.58% <ø> (-68.49%) ⬇️
ptq 67.31% <ø> (-20.43%) ⬇️

@KodiaqQ KodiaqQ marked this pull request as ready for review March 7, 2024 18:03
@KodiaqQ KodiaqQ requested a review from a team as a code owner March 7, 2024 18:03
Copy link
Contributor

@alexsu52 alexsu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexanderDokuchaev AlexanderDokuchaev merged commit b2a3ccf into openvinotoolkit:develop Mar 11, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Public API-impacting changes documentation Improvements or additions to documentation NNCF Common Pull request that updates NNCF Common NNCF PT Pull requests that updates NNCF PyTorch NNCF TF Pull requests that updates NNCF TensorFlow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants