Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scale estimation/rectification for int4 compression #2549
Scale estimation/rectification for int4 compression #2549
Changes from all commits
9f29c53
2b657f3
00c8d12
eab7f49
3908ef9
8961142
3bc4ec2
0292b2a
7cec4ce
18313df
9d4c122
b35de99
c69d8eb
7999c6b
f5111a8
bd5c1e1
ad9124b
d1b566c
0d19c69
c89c939
5e7d899
81f02fc
8ab8f36
c85a415
1f13800
680939b
1cd2c7f
2fb43bd
4371295
d41e29c
6a42c35
413eec2
065e4f4
007d92d
ad81ac0
6771faf
8d2a842
0c2a1f7
afcf3b3
140c31f
795742d
f06095e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this is out of scope of the PR, but my opinion is
__init__
parameters should be look like this:This comment is something to think about.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO: