Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port .take functionality for Good First Issues from OpenVINO repository #2544

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

p-wysocki
Copy link
Contributor

Changes / Reason for changes

Merging this workflow allows open source contributors to comment .take under a Good First Issue and automatically pick it up. The community is already accustomed to that and currently it does not work in NNCF GFIs.

Related tickets

N/A

Tests

.take has been proven to be a convenient feature for both project maintainers and open source contributors. Here it is in OpenVINO repo: https://github.com/openvinotoolkit/openvino/blob/master/.github/workflows/assign_issue.yml.

@p-wysocki p-wysocki requested a review from a team as a code owner March 4, 2024 07:34
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.63%. Comparing base (d931f84) to head (b183799).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2544      +/-   ##
===========================================
- Coverage    90.82%   84.63%   -6.19%     
===========================================
  Files          498      498              
  Lines        45600    45553      -47     
===========================================
- Hits         41417    38555    -2862     
- Misses        4183     6998    +2815     

see 56 files with indirect coverage changes

Flag Coverage Δ
COMMON 42.73% <ø> (+<0.01%) ⬆️
ONNX 34.77% <ø> (-0.01%) ⬇️
OPENVINO ∅ <ø> (∅)
TENSORFLOW 29.65% <ø> (ø)
TORCH 66.01% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
common 93.10% <ø> (-0.66%) ⬇️
torch 93.43% <ø> (ø)
tensorflow 93.96% <ø> (ø)
onnx 93.05% <ø> (ø)
openvino 25.58% <ø> (-68.49%) ⬇️
ptq 67.31% <ø> (-19.64%) ⬇️

@MaximProshin MaximProshin requested a review from alexsu52 March 4, 2024 07:41
@MaximProshin
Copy link
Collaborator

@alexsu52 , take a look

Copy link
Contributor

@alexsu52 alexsu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@alexsu52 alexsu52 merged commit 760d1d5 into openvinotoolkit:develop Mar 5, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants