[ONNX] Fix adding output nodes in NNCFGraph #2538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2538 +/- ##
============================================
- Coverage 91.16% 77.93% -13.23%
============================================
Files 494 494
Lines 45373 45374 +1
============================================
- Hits 41363 35363 -6000
- Misses 4010 10011 +6001
... and 104 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Added test |
alexsu52
reviewed
Mar 8, 2024
| "0 Conv1" [id=0, type=Conv]; | ||
| "1 nncf_model_input_0" [id=1, type=nncf_model_input]; | ||
| "2 nncf_model_output_0" [id=2, type=nncf_model_output]; | ||
| "3 nncf_model_output_1" [id=3, type=nncf_model_output]; |
There was a problem hiding this comment.
It looks like the graph is not connected. Let's discuss offline what the impact on algorithms is.
There was a problem hiding this comment.
The logic was updated. Outputs with no parent node are not added to the NNCFGraph.
|
E2E ONNX - 654 passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Do not add edges for the output node if it has no parents. E.g. output is put on the initializer.
Reason for changes
125248
Related tickets
125248
Tests
Checked on reproducer in the ticket