Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PTQ] Metatypes with bias list alignment #2506

Merged
merged 9 commits into from
Mar 21, 2024

Conversation

KodiaqQ
Copy link
Collaborator

@KodiaqQ KodiaqQ commented Feb 21, 2024

Changes

  • Reduced metatypes in OPERATIONS_WITH_BIAS list for ONNX;
  • Reduced metatypes in OPERATIONS_WITH_BIAS list for PyTorch;
  • Separated GroupConvolution from the Convolutions on ONNX;

Reason for changes

  • Alignment for algorithms between backends;

Related tickets

  • 133198
  • 104166
  • 106469

Tests

  • post_training_quantization/323 - failed with regressions for ONNX (as expected)
  • post_training_quantization/324 - passed (updated references)

@github-actions github-actions bot added NNCF OpenVINO Pull requests that updates NNCF OpenVINO NNCF ONNX Pull requests that updates NNCF ONNX labels Feb 21, 2024
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.84%. Comparing base (86ea8f6) to head (a87c1d1).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2506      +/-   ##
===========================================
- Coverage    91.18%   84.84%   -6.34%     
===========================================
  Files          492      492              
  Lines        45103    45122      +19     
===========================================
- Hits         41129    38286    -2843     
- Misses        3974     6836    +2862     
Files Coverage Δ
nncf/onnx/graph/metatypes/groups.py 100.00% <ø> (ø)
nncf/onnx/graph/metatypes/onnx_metatypes.py 99.60% <100.00%> (+0.01%) ⬆️
nncf/openvino/graph/metatypes/groups.py 100.00% <ø> (ø)
nncf/torch/graph/operator_metatypes.py 99.23% <ø> (ø)

... and 56 files with indirect coverage changes

Flag Coverage Δ
COMMON 43.93% <ø> (ø)
ONNX 34.67% <100.00%> (+0.01%) ⬆️
OPENVINO ∅ <ø> (∅)
TENSORFLOW 29.85% <0.00%> (-0.02%) ⬇️
TORCH 65.74% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
common 93.11% <ø> (-0.66%) ⬇️
torch 93.59% <ø> (ø)
tensorflow 93.74% <ø> (ø)
onnx 93.15% <100.00%> (+0.09%) ⬆️
openvino 25.58% <ø> (-68.49%) ⬇️
ptq 69.79% <ø> (-20.43%) ⬇️

@github-actions github-actions bot added the NNCF PT Pull requests that updates NNCF PyTorch label Feb 22, 2024
@github-actions github-actions bot removed the NNCF PT Pull requests that updates NNCF PyTorch label Feb 29, 2024
@KodiaqQ KodiaqQ force-pushed the nm/extend_layers_with_bias branch from 6c727ef to c0fe3a7 Compare March 6, 2024 08:04
@github-actions github-actions bot added the NNCF PT Pull requests that updates NNCF PyTorch label Mar 6, 2024
@KodiaqQ KodiaqQ force-pushed the nm/extend_layers_with_bias branch from d469995 to ddbac43 Compare March 7, 2024 14:47
@KodiaqQ KodiaqQ marked this pull request as ready for review March 13, 2024 16:02
@KodiaqQ KodiaqQ requested a review from a team as a code owner March 13, 2024 16:02
@KodiaqQ KodiaqQ self-assigned this Mar 13, 2024
@github-actions github-actions bot added the NNCF PTQ Pull requests that updates NNCF PTQ label Mar 14, 2024
@KodiaqQ KodiaqQ force-pushed the nm/extend_layers_with_bias branch from a2c369f to fdf477a Compare March 14, 2024 08:01
@KodiaqQ KodiaqQ requested a review from alexsu52 March 14, 2024 12:43
@KodiaqQ KodiaqQ force-pushed the nm/extend_layers_with_bias branch from fdf477a to a87c1d1 Compare March 15, 2024 12:34
Copy link
Contributor

@alexsu52 alexsu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KodiaqQ
Copy link
Collaborator Author

KodiaqQ commented Mar 21, 2024

@AlexanderDokuchaev, @kshpv, please, review.

@KodiaqQ KodiaqQ assigned alexsu52 and unassigned KodiaqQ Mar 21, 2024
@KodiaqQ KodiaqQ merged commit 08cb49e into openvinotoolkit:develop Mar 21, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NNCF ONNX Pull requests that updates NNCF ONNX NNCF OpenVINO Pull requests that updates NNCF OpenVINO NNCF PT Pull requests that updates NNCF PyTorch NNCF PTQ Pull requests that updates NNCF PTQ
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants