Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PT][WC] Add WC tests for functional models #2446

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

l-bat
Copy link
Collaborator

@l-bat l-bat commented Feb 5, 2024

Changes

Fixed bug with channel_idx for Torch Conv metatypes
Fixed bug in get_module_by_name() if base model has weights as a torch.nn.Parameter

Reason for changes

Related tickets

124822

Tests

Added test_compress_weights_functional_model

@l-bat l-bat requested a review from a team as a code owner February 5, 2024 13:55
@github-actions github-actions bot added NNCF PT Pull requests that updates NNCF PyTorch NNCF PTQ Pull requests that updates NNCF PTQ labels Feb 5, 2024
Copy link

codecov bot commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1391667) 91.10% compared to head (a030ee6) 66.17%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #2446       +/-   ##
============================================
- Coverage    91.10%   66.17%   -24.94%     
============================================
  Files          497      497               
  Lines        45220    45226        +6     
============================================
- Hits         41198    29928    -11270     
- Misses        4022    15298    +11276     
Files Coverage Δ
...ion/algorithms/weight_compression/torch_backend.py 85.08% <100.00%> (+1.93%) ⬆️

... and 195 files with indirect coverage changes

Flag Coverage Δ
COMMON ?
ONNX ?
OPENVINO ?
TENSORFLOW ?
TORCH 66.17% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
common 86.00% <ø> (-7.36%) ⬇️
torch 93.40% <100.00%> (+<0.01%) ⬆️
tensorflow 0.00% <ø> (-94.00%) ⬇️
onnx 0.00% <ø> (-98.02%) ⬇️
openvino 26.03% <ø> (-68.40%) ⬇️
ptq 51.75% <100.00%> (-37.60%) ⬇️

@l-bat l-bat requested a review from alexsu52 February 5, 2024 15:17
Copy link
Contributor

@alexsu52 alexsu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@alexsu52 alexsu52 merged commit 2872f27 into openvinotoolkit:develop Feb 5, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NNCF PT Pull requests that updates NNCF PyTorch NNCF PTQ Pull requests that updates NNCF PTQ
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants