Patch missed magic functions #2298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2298 +/- ##
========================================
Coverage 90.76% 90.77%
========================================
Files 486 487 +1
Lines 43783 43806 +23
========================================
+ Hits 39741 39764 +23
Misses 4042 4042
Flags with carried forward coverage won't be shown. Click here to find out more.
|
alexsu52
reviewed
Nov 30, 2023
| @@ -122,35 +122,51 @@ class FunctionsToPatchWithoutTracing: | |||
| class MagicFunctionsToPatch: | |||
| MAGIC_FUNCTIONS_TO_PATCH = { | |||
| NamespaceTarget.TORCH_TENSOR: [ | |||
| "__abs__", | |||
There was a problem hiding this comment.
Metatypes should be defined for all new operations and added support in NNCF algorithms.
|
@AlexanderDokuchaev, is it possible to add some unit tests for this change? |
AlexanderDokuchaev
force-pushed
the
ad/fix_trace_graph
branch
from
2d62878 to
2c61a3f
Compare
AlexanderDokuchaev
force-pushed
the
ad/fix_trace_graph
branch
2 times, most recently
from
6b6ac7d to
7828c94
Compare
kshpv
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
PTNegativeMetatypefor-tensorandtensor.neg()operations.Related tickets
124852
Tests
test_patch_magic_functions
test_op_for_patch_magic_functions
models_hub_test
91 failed, 602 passed, after83 failed, 610 passed