Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove to_device from PTEngine #2260

Merged

Conversation

AlexanderDokuchaev
Copy link
Collaborator

@AlexanderDokuchaev AlexanderDokuchaev commented Nov 11, 2023

Changes

Remove logic to set device in PTEngine, to support multi-device model #2253

@AlexanderDokuchaev AlexanderDokuchaev requested a review from a team as a code owner November 11, 2023 01:56
@github-actions github-actions bot added the NNCF PT Pull requests that updates NNCF PyTorch label Nov 11, 2023
Copy link

codecov bot commented Nov 11, 2023

Codecov Report

Merging #2260 (94654ff) into develop (b4b2e19) will increase coverage by 54.10%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #2260       +/-   ##
============================================
+ Coverage    36.60%   90.71%   +54.10%     
============================================
  Files          485      485               
  Lines        43722    43715        -7     
============================================
+ Hits         16006    39656    +23650     
+ Misses       27716     4059    -23657     
Flag Coverage Δ
COMMON 15.82% <ø> (+<0.01%) ⬆️
ONNX 33.83% <ø> (+<0.01%) ⬆️
OPENVINO 38.59% <ø> (?)
TENSORFLOW 30.04% <ø> (?)
TORCH 62.71% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
nncf/torch/engine.py 100.00% <ø> (+100.00%) ⬆️

... and 342 files with indirect coverage changes

Copy link
Contributor

@alexsu52 alexsu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you provide test example results?

@AlexanderDokuchaev
Copy link
Collaborator Author

@alexsu52 test_examples/138

@alexsu52 alexsu52 merged commit 610e800 into openvinotoolkit:develop Nov 15, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NNCF PT Pull requests that updates NNCF PyTorch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants