Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct device assignment for ExactInputsInfo #2252

Merged
merged 3 commits into from
Nov 9, 2023

Conversation

vshampor
Copy link
Contributor

@vshampor vshampor commented Nov 8, 2023

Changes

As stated in the title

Reason for changes

PTQ PT CUDA test cases fail

Related tickets

124679

Tests

test_input_infos_respect_device_setting

@github-actions github-actions bot added the NNCF PT Pull requests that updates NNCF PyTorch label Nov 8, 2023
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #2252 (b2c5820) into develop (96de397) will decrease coverage by 4.61%.
Report is 1 commits behind head on develop.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2252      +/-   ##
===========================================
- Coverage    90.49%   85.89%   -4.61%     
===========================================
  Files          485      485              
  Lines        43659    43609      -50     
===========================================
- Hits         39511    37456    -2055     
- Misses        4148     6153    +2005     
Flag Coverage Δ
COMMON 15.75% <0.00%> (-0.02%) ⬇️
ONNX ?
OPENVINO 38.58% <11.11%> (+0.11%) ⬆️
TENSORFLOW 30.03% <0.00%> (-0.05%) ⬇️
TORCH 62.65% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
nncf/torch/dynamic_graph/io_handling.py 93.98% <100.00%> (-4.78%) ⬇️

... and 54 files with indirect coverage changes

@vshampor vshampor marked this pull request as ready for review November 8, 2023 15:55
@vshampor vshampor requested a review from a team as a code owner November 8, 2023 15:55
Copy link
Collaborator

@daniil-lyakhov daniil-lyakhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vshampor
Copy link
Contributor Author

vshampor commented Nov 8, 2023

test_examples build 131 no longer fails with the relevant errors.

@vshampor vshampor merged commit 29bfc89 into openvinotoolkit:develop Nov 9, 2023
6 checks passed
@vshampor vshampor deleted the fix_examples branch January 9, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NNCF PT Pull requests that updates NNCF PyTorch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants