Update networkx and remove pyparsing limitation #2241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
dependencies
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2241 +/- ##
===========================================
+ Coverage 90.49% 90.71% +0.22%
===========================================
Files 485 485
Lines 43659 43685 +26
===========================================
+ Hits 39511 39631 +120
+ Misses 4148 4054 -94
Flags with carried forward coverage won't be shown. Click here to find out more.
|
github-actions
bot
added
NNCF OpenVINO
This reverts commit 78df48a.
github-actions
bot
removed
NNCF OpenVINO
nncf/common/utils/dot_file_rw.py
Outdated
|
|
||
| class _Direction(IntEnum): | ||
| TO_DOT = 0 | ||
| FROM_DOT = 0 |
There was a problem hiding this comment.
Unused, removed, thanks!
daniil-lyakhov
approved these changes
Nov 10, 2023
vshampor
added a commit
that referenced
this pull request
Jan 2, 2024
### Changes As stated in the title ### Reason for changes These are the leftovers from #2241. ### Related tickets 69520 ### Tests torch/TF precommit --------- Co-authored-by: Vasily Shamporov <[email protected]>
vshampor
added a commit
to vshampor/nncf
that referenced
this pull request
Jan 2, 2024
### Changes As stated in the title ### Reason for changes These are the leftovers from openvinotoolkit#2241. ### Related tickets 69520 ### Tests torch/TF precommit --------- Co-authored-by: Vasily Shamporov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Networkx was updated to allow 3.1, pyparsing limitation was removed. Will now replace the disallowed colon symbols
:during reads and writes of .dot graphs.Reason for changes
OV is now at the networkx 3.1, and we should be aligned at least on the major version for better DX.
Related tickets
69520
Tests
Existing graph-checking tests