-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch PyTorch PTQ to common implementation #2227
Switch PyTorch PTQ to common implementation #2227
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2227 +/- ##
============================================
+ Coverage 36.40% 89.61% +53.21%
============================================
Files 486 485 -1
Lines 43508 43421 -87
============================================
+ Hits 15838 38912 +23074
+ Misses 27670 4509 -23161
Flags with carried forward coverage won't be shown. Click here to find out more.
|
post_training_quantization/193/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor
Co-authored-by: Daniil Lyakhov <[email protected]>
Co-authored-by: Daniil Lyakhov <[email protected]>
@vshampor , please state explicitly if there are any remaining comments from you that should be applied or you're ok to merge it. |
I'm not blocking it, but the change will have to be aligned with #2196 in one way or another. |
### Changes - Update torch examples, added argument `--export-model-path` instead of `--to-onnx` that select output type by suffix '.xml' or '.onnx'. - Update tests to use Command to run examples. - Remove tests of q_dq export path. - Remove code to make html report, now metrics dumps in `results.csv`. - Added "build url" in `results.csv`. - Actualize reference metrics. - Move normalization of input to accuracy cheker configs. - Use `target_ov` and `target_pt` to define reference metrics for backends. - Skip test `unet_mapillary_int8` and `unet_mapillary_magnitude_sparsity_int8` models by 123448. - Skip `resnet18_imagenet_binarization_dorefa` model by 22543. Updates in CI: - Update script to report `final e2e_result.html` for e2e tests. - Now if any test falls trigger_job will be fails. After merge requires update ci-pipelines. ### Related tickets 117885 ### Tests tests/torch/test_sota_checkpoints.py ### TODO - update metrics after merge #2227 - check metrics after #2211
Changes
nncf.quantize
to post training implementation for PT backendRelated tickets
119910