[PTQ][Experimental stats] MAD and Percentile aggregators accept dynamic tensors #2221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
NNCF TF
daniil-lyakhov
commented
Oct 25, 2023
| return retval | ||
|
|
||
|
|
||
| def _moveaxes_flatten_cat( |
There was a problem hiding this comment.
This function is working correctly only for cases when 0 is present in original aggregation axes. I didn't implement additional logic for other cases because it will be impossible after the #2213 anyway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On top of #2213
Changes
MAD and Percentile aggregators accepts tensors that have different axes along aggregation axes
Reason for changes
To align behaviour of the experimental tensor collectors with common tensor collectors
Related tickets
123519
Tests