Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PTQ][OV] SQ for Convolutions #2204

Merged
merged 24 commits into from
Nov 7, 2023
Merged

Conversation

KodiaqQ
Copy link
Collaborator

@KodiaqQ KodiaqQ commented Oct 17, 2023

Changes

  • Updated SmoothQuant algorithm to work with Convolution layers;

Reason for changes

  • Better accuracy results in some cases;

Related tickets

  • 113591

Tests

@github-actions github-actions bot added NNCF OpenVINO Pull requests that updates NNCF OpenVINO NNCF PTQ Pull requests that updates NNCF PTQ labels Oct 17, 2023
@openvino-nncf-ci openvino-nncf-ci added the API Public API-impacting changes label Oct 18, 2023
@KodiaqQ KodiaqQ marked this pull request as ready for review October 30, 2023 09:43
@KodiaqQ KodiaqQ requested a review from a team as a code owner October 30, 2023 09:43
@KodiaqQ KodiaqQ changed the title [PTQ] SQ experimental [PTQ] SQ for Convolutions Oct 30, 2023
@KodiaqQ KodiaqQ changed the title [PTQ] SQ for Convolutions [PTQ][OV] SQ for Convolutions Oct 30, 2023
@github-actions github-actions bot added NNCF PT Pull requests that updates NNCF PyTorch NNCF ONNX Pull requests that updates NNCF ONNX labels Oct 30, 2023
@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Merging #2204 (1846565) into develop (f344b1d) will increase coverage by 49.44%.
Report is 9 commits behind head on develop.
The diff coverage is 87.37%.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #2204       +/-   ##
============================================
+ Coverage    36.45%   85.90%   +49.44%     
============================================
  Files          486      485        -1     
  Lines        43507    43565       +58     
============================================
+ Hits         15860    37424    +21564     
+ Misses       27647     6141    -21506     
Flag Coverage Δ
COMMON 15.76% <13.59%> (?)
OPENVINO 38.54% <87.37%> (?)
TENSORFLOW 30.06% <13.59%> (?)
TORCH 62.64% <24.27%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
nncf/common/graph/graph.py 96.37% <ø> (+21.16%) ⬆️
nncf/openvino/graph/nncf_graph_builder.py 99.09% <100.00%> (+99.09%) ⬆️
nncf/quantization/advanced_parameters.py 91.78% <100.00%> (+45.35%) ⬆️
nncf/quantization/algorithms/min_max/algorithm.py 98.12% <100.00%> (+2.51%) ⬆️
...cf/quantization/algorithms/smooth_quant/backend.py 100.00% <100.00%> (+100.00%) ⬆️
...zation/algorithms/smooth_quant/openvino_backend.py 97.61% <100.00%> (+97.61%) ⬆️
.../quantization/algorithms/smooth_quant/algorithm.py 96.59% <96.77%> (+74.29%) ⬆️
...tion/algorithms/hyperparameter_tuner/param_grid.py 52.50% <33.33%> (-0.14%) ⬇️
nncf/openvino/pot/quantization/quantize_model.py 66.66% <44.44%> (+66.66%) ⬆️
.../quantization/algorithms/post_training/pipeline.py 85.71% <54.54%> (-4.29%) ⬇️

... and 361 files with indirect coverage changes

@KodiaqQ KodiaqQ requested review from l-bat and alexsu52 November 6, 2023 11:48
nncf/openvino/pot/quantization/quantize_model.py Outdated Show resolved Hide resolved
@github-actions github-actions bot added the NNCF Common Pull request that updates NNCF Common label Nov 6, 2023
Copy link
Contributor

@alexsu52 alexsu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KodiaqQ KodiaqQ merged commit 074e749 into openvinotoolkit:develop Nov 7, 2023
6 checks passed
daniil-lyakhov pushed a commit to daniil-lyakhov/nncf that referenced this pull request Nov 10, 2023
### Changes

- Updated SmoothQuant algorithm to work with Convolution layers;

### Reason for changes

- Better accuracy results in some cases;

### Related tickets

- 113591

### Tests

---------

Co-authored-by: Liubov Talamanova <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Public API-impacting changes NNCF Common Pull request that updates NNCF Common NNCF ONNX Pull requests that updates NNCF ONNX NNCF OpenVINO Pull requests that updates NNCF OpenVINO NNCF PT Pull requests that updates NNCF PyTorch NNCF PTQ Pull requests that updates NNCF PTQ
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants