-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PTQ][OV] SQ for Convolutions #2204
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
NNCF OpenVINO
Pull requests that updates NNCF OpenVINO
NNCF PTQ
Pull requests that updates NNCF PTQ
labels
Oct 17, 2023
KodiaqQ
force-pushed
the
nm/sq_for_convs
branch
from
October 18, 2023 10:31
90dc04e
to
211fc0a
Compare
github-actions
bot
added
NNCF PT
Pull requests that updates NNCF PyTorch
NNCF ONNX
Pull requests that updates NNCF ONNX
labels
Oct 30, 2023
KodiaqQ
force-pushed
the
nm/sq_for_convs
branch
from
October 30, 2023 17:31
694d267
to
fa3cac0
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2204 +/- ##
============================================
+ Coverage 36.45% 85.90% +49.44%
============================================
Files 486 485 -1
Lines 43507 43565 +58
============================================
+ Hits 15860 37424 +21564
+ Misses 27647 6141 -21506
Flags with carried forward coverage won't be shown. Click here to find out more.
|
alexsu52
requested changes
Nov 1, 2023
l-bat
reviewed
Nov 6, 2023
l-bat
approved these changes
Nov 6, 2023
Co-authored-by: Liubov Talamanova <[email protected]>
alexsu52
approved these changes
Nov 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
daniil-lyakhov
pushed a commit
to daniil-lyakhov/nncf
that referenced
this pull request
Nov 10, 2023
### Changes - Updated SmoothQuant algorithm to work with Convolution layers; ### Reason for changes - Better accuracy results in some cases; ### Related tickets - 113591 ### Tests --------- Co-authored-by: Liubov Talamanova <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
API
Public API-impacting changes
NNCF Common
Pull request that updates NNCF Common
NNCF ONNX
Pull requests that updates NNCF ONNX
NNCF OpenVINO
Pull requests that updates NNCF OpenVINO
NNCF PT
Pull requests that updates NNCF PyTorch
NNCF PTQ
Pull requests that updates NNCF PTQ
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Reason for changes
Related tickets
Tests