Fix multithreading #2198
Merged
Fix multithreading #2198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2198 +/- ##
========================================
Coverage 36.57% 36.57%
========================================
Files 484 484
Lines 43300 43310 +10
========================================
+ Hits 15837 15841 +4
- Misses 27463 27469 +6
|
|
Failed build: 10733 |
alexsu52
reviewed
Oct 13, 2023
Co-authored-by: Alexander Suslov <[email protected]>
|
Successful build: 10738 |
alexsu52
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The
_multithreading_calculation_ranking_scoredoes not work when len(groups_to_rank) < self._num_workersReason for changes
IndexError: pop from empty list
Related tickets
N/A
Tests
N/A