-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cleanup_torchscript_cache
to test_quantize_conformance.py
#2171
Merged
alexsu52
merged 2 commits into
openvinotoolkit:develop
from
AlexanderDokuchaev:ad/ptq_test_mem_leak
Oct 9, 2023
Merged
Add cleanup_torchscript_cache
to test_quantize_conformance.py
#2171
alexsu52
merged 2 commits into
openvinotoolkit:develop
from
AlexanderDokuchaev:ad/ptq_test_mem_leak
Oct 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vshampor
reviewed
Oct 4, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2171 +/- ##
===========================================
- Coverage 36.12% 36.09% -0.03%
===========================================
Files 478 480 +2
Lines 42711 43243 +532
===========================================
+ Hits 15429 15610 +181
- Misses 27282 27633 +351 |
AlexanderDokuchaev
force-pushed
the
ad/ptq_test_mem_leak
branch
from
October 5, 2023 22:13
13a1ac4
to
bfefa7c
Compare
AlexanderDokuchaev
changed the title
Run ptq tests in subprocess
Add Oct 5, 2023
cleanup_torchscript_cache
to test_quantize_conformance.py
vshampor
approved these changes
Oct 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job tracking this down to actual source.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add
cleanup_torchscript_cache
function to test_quantize_conformance.pyReason for changes
After run torch.jit.trace in convert_model, PyTorch does not clear the trace cache automatically.
Same function in torch test and openvino notebok:
https://github.com/pytorch/pytorch/blob/main/torch/testing/_internal/jit_utils.py#L59
https://github.com/openvinotoolkit/openvino_notebooks/blob/1932d4b4e99116bdedaa620c9dc92069fbb1f05e/notebooks/236-stable-diffusion-v2/implementation/conversion_helper_utils.py#L8