Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy external quantizer storage names #2163

Merged

Conversation

vshampor
Copy link
Contributor

Changes

Legacy quantizer storage names in checkpoints were removed

Reason for changes

The format had changed after the NNCFNetwork rework, and the deprecation warning has been in place for two releases now.

Related tickets

121535

Tests

test_load_model_state

@vshampor vshampor requested a review from a team as a code owner September 26, 2023 17:29
@github-actions github-actions bot added the NNCF PT Pull requests that updates NNCF PyTorch label Sep 26, 2023
@vshampor
Copy link
Contributor Author

sota_pytorch_eval build 483 running with updated checkpoint files

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #2163 (24744d5) into develop (36f45a2) will increase coverage by 0.00%.
Report is 1 commits behind head on develop.
The diff coverage is 16.66%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2163   +/-   ##
========================================
  Coverage    36.10%   36.11%           
========================================
  Files          478      478           
  Lines        42726    42704   -22     
========================================
- Hits         15426    15422    -4     
+ Misses       27300    27282   -18     
Files Coverage Δ
nncf/torch/nncf_network.py 28.68% <100.00%> (-0.28%) ⬇️
nncf/torch/checkpoint_loading.py 19.83% <0.00%> (+0.76%) ⬆️

@vshampor
Copy link
Contributor Author

Build 483 OK except for ssd300_mobilenet_voc; fixed the relevant checkpoint and checked in build 486, also OK

@vshampor vshampor force-pushed the remove_legacy_external_quant branch from 6a5609b to 24744d5 Compare September 27, 2023 09:03
@vshampor vshampor merged commit 304bd1d into openvinotoolkit:develop Sep 27, 2023
daniil-lyakhov pushed a commit to daniil-lyakhov/nncf that referenced this pull request Sep 27, 2023
### Changes
Legacy quantizer storage names in checkpoints were removed

### Reason for changes
The format had changed after the NNCFNetwork rework, and the deprecation
warning has been in place for two releases now.

### Related tickets
121535

### Tests
test_load_model_state
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NNCF PT Pull requests that updates NNCF PyTorch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants