Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add table of corresponding versions for backends #2161

Merged

Conversation

AlexanderDokuchaev
Copy link
Collaborator

Changes

Add table of corresponding versions for backends.

Related tickets

120873

@AlexanderDokuchaev AlexanderDokuchaev requested a review from a team as a code owner September 26, 2023 09:03
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Sep 26, 2023

| NNCF | OpenVINO | PyTorch | ONNX | ONNX Runtime | TensorFlow | Python |
| ------- | ---------- | ------------------- | -------- | -------------- | ------------ | ---------------- |
| `2.6.0` | `2023.1.0` | `>=1.13.0`, `<2.1` | `1.13.1` | `1.14.1` | `2.12.0` | `>=3.7`, `<3.11` |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What backend versions do you want to provide? Do I mean backend versions that were used for testing or backend versions that were stated to be supported? In any case, please, align your table with Readme.txt.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated, get versions from README.md

@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #2161 (75f4dfb) into develop (f6d958f) will increase coverage by 36.14%.
Report is 41 commits behind head on develop.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #2161       +/-   ##
============================================
+ Coverage         0   36.14%   +36.14%     
============================================
  Files            0      480      +480     
  Lines            0    43005    +43005     
============================================
+ Hits             0    15546    +15546     
- Misses           0    27459    +27459     

see 480 files with indirect coverage changes

Copy link
Contributor

@alexsu52 alexsu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@MaximProshin
Copy link
Collaborator

It means we should update it every NNCF release. How do we secure it?


| NNCF | OpenVINO | PyTorch | ONNX | TensorFlow | Python |
| ------- | ---------- | ------------------- | -------- | ----------------------- | ------- |
| `2.6.0` | `2023.1.0` | `>=1.13.0`, `<2.1` | `1.13.1` | `>=2.4.0`, `<=2.12.0` | `>=3.7` |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think "it's recommended". We should recommend what is tested and according to https://github.com/openvinotoolkit/nncf#system-requirements: This repository is tested on Python* 3.8.10, PyTorch* 2.0.1 (NVidia CUDA* Toolkit 11.7) and TensorFlow* 2.12.1 (NVidia CUDA* Toolkit 11.8).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you know, Torch and TensorFlow has backward compatibility tests for provided versions, OpenVINO and ONNX does not have. Still, what should be considered the recommended versions, those that provide full validation?

Copy link
Collaborator Author

@AlexanderDokuchaev AlexanderDokuchaev Oct 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated PT and TF versions according #system-requirements:

Update current test requirements for PT:

  • cuda 11.8 instead of 11.7

Python: only 3.8

@AlexanderDokuchaev AlexanderDokuchaev force-pushed the ad/corresponding_versions branch from 7321094 to d9a919e Compare October 3, 2023 14:26
README.md Outdated Show resolved Hide resolved
| ------- | ---------- | ------------------ | -------- | ---------- | ------- |
| `2.6.0` | `2023.1.0` | `1.13.1`, `2.0.1` | `1.13.1` | `2.12.0` | `3.8` |
| `2.5.0` | `2023.0.0` | `3.8.10`, `1.13.1` | `1.13.1` | `2.11.1` | `3.8` |
| `2.4.0` | `2022.1.0` | `3.8.10`, `1.12.1` | `1.12.0` | `2.8.2` | `3.8` |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, specify one version for Torch.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@alexsu52 alexsu52 merged commit 2c417f5 into openvinotoolkit:develop Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants