Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linear_squeeze_arithmetical_activations pattern #2142

Conversation

alexsu52
Copy link
Contributor

Changes

  • Added LINEAR_SQUEEZE_ARITHMETIC_ACTIVATIONS pattern
  • Added ONNXGlobalMaxPoolMetatype metatype for ONNX backend

Reason for changes

Fixed FakeQuantize operations placement

Related tickets

ref: 113396

Tests

N/A

@alexsu52 alexsu52 requested a review from a team as a code owner September 18, 2023 07:34
@alexsu52 alexsu52 requested a review from KodiaqQ September 18, 2023 07:34
@github-actions github-actions bot added NNCF PT Pull requests that updates NNCF PyTorch NNCF Common Pull request that updates NNCF Common NNCF OpenVINO Pull requests that updates NNCF OpenVINO NNCF ONNX Pull requests that updates NNCF ONNX labels Sep 18, 2023
@alexsu52 alexsu52 requested a review from kshpv September 18, 2023 07:35
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #2142 (ccded55) into develop (2b14d25) will increase coverage by 36.24%.
Report is 1 commits behind head on develop.
The diff coverage is 63.63%.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #2142       +/-   ##
============================================
+ Coverage         0   36.24%   +36.24%     
============================================
  Files            0      477      +477     
  Lines            0    42566    +42566     
============================================
+ Hits             0    15428    +15428     
- Misses           0    27138    +27138     
Files Changed Coverage Δ
nncf/onnx/graph/metatypes/groups.py 100.00% <ø> (ø)
nncf/openvino/hardware/fused_patterns.py 0.00% <0.00%> (ø)
nncf/common/graph/patterns/patterns.py 93.22% <100.00%> (ø)
nncf/onnx/graph/metatypes/onnx_metatypes.py 99.57% <100.00%> (ø)
nncf/onnx/hardware/fused_patterns.py 100.00% <100.00%> (ø)

... and 472 files with indirect coverage changes

@alexsu52 alexsu52 force-pushed the as/linear_squeeze_arithmetical_activations branch from 1bb1422 to ccded55 Compare September 18, 2023 10:02
@alexsu52 alexsu52 force-pushed the as/linear_squeeze_arithmetical_activations branch from ccded55 to dc48ca5 Compare September 18, 2023 13:17
@KodiaqQ
Copy link
Collaborator

KodiaqQ commented Sep 18, 2023

Are we aligned with the POT now, @alexsu52?

@alexsu52
Copy link
Contributor Author

Are we aligned with the POT now, @alexsu52?

POT has another model representation. I could not compare with POT.

Copy link
Collaborator

@KodiaqQ KodiaqQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, fill the ticket with the new bias representation as we discussed.

@KodiaqQ KodiaqQ merged commit 631a7b8 into openvinotoolkit:develop Sep 18, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NNCF Common Pull request that updates NNCF Common NNCF ONNX Pull requests that updates NNCF ONNX NNCF OpenVINO Pull requests that updates NNCF OpenVINO NNCF PT Pull requests that updates NNCF PyTorch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants