-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PTQ][Torch][Native] Experimental tensor statistics migration #2117
[PTQ][Torch][Native] Experimental tensor statistics migration #2117
Conversation
@vshampor, @AlexanderDokuchaev, this PR is conflicting with PRs #2032, #2058. We should decide how we will be merging as all three PRs are huge |
58146aa
to
681c357
Compare
681c357
to
79cf566
Compare
I closed the #2032, but there will be another one with the algo unification. You should proceed with merging this PR disregarding mine, though - I will rebase my changes accordingly. |
e1fbd21
to
e9aaa44
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2117 +/- ##
===========================================
- Coverage 36.24% 36.13% -0.11%
===========================================
Files 477 480 +3
Lines 42570 42998 +428
===========================================
+ Hits 15428 15539 +111
- Misses 27142 27459 +317
|
884aecb
to
53b2067
Compare
@vshampor, I've renamed percentile and have resolved all relative comments, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better now, still some changes required.
43c29f7
to
ef99ed4
Compare
b3fb6b2
to
cca8660
Compare
8576c17
to
5e859c2
Compare
5e859c2
to
bf9c611
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you provide onnx e2e results?
onnx nightly e2e build 455 finished successfully |
Changes
no_outlier_map
function refactored to not depend on shape of input tensor to make it possible to unify Torch and OV backends as they are using different shape statisticsReason for changes
Related tickets
109665
Tests
TODO:
no_outlier_map
performs as good as previous implementation