Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry sanity sample runs on segfault #2112

Closed
wants to merge 3 commits into from

Conversation

vshampor
Copy link
Contributor

@vshampor vshampor commented Sep 6, 2023

Changes

As stated in the title

Reason for changes

Working around sporadic segfaults in Torch sanity samples due to torch 2.0

Related tickets

119128

Tests

torch test_sanity_sample

@vshampor vshampor requested a review from a team as a code owner September 6, 2023 11:40
@github-actions github-actions bot added the NNCF PT Pull requests that updates NNCF PyTorch label Sep 6, 2023
@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Merging #2112 (3ad438c) into develop (9c30388) will decrease coverage by 0.01%.
Report is 7 commits behind head on develop.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2112      +/-   ##
===========================================
- Coverage    35.92%   35.91%   -0.01%     
===========================================
  Files          477      476       -1     
  Lines        42451    42445       -6     
===========================================
- Hits         15251    15245       -6     
  Misses       27200    27200              

see 17 files with indirect coverage changes

@vshampor
Copy link
Contributor Author

vshampor commented Sep 7, 2023

run onnx pre-commit tests
run openvino pre-commit tests
run tensorflow pre-commit tests

@AlexanderDokuchaev
Copy link
Collaborator

This workaround for sanity tests has already been rejected by @alexsu52 and myself in the discussion of #2058

@vshampor
Copy link
Contributor Author

vshampor commented Sep 8, 2023

This workaround for sanity tests has already been rejected by @alexsu52 and myself in the discussion of #2058

Well, I don't reject it, I endorse it. I also see no relevant discussions either in #2092 or #2058

@AlexanderDokuchaev
Copy link
Collaborator

After #2149 it can be closed?

@vshampor
Copy link
Contributor Author

After #2149 it can be closed?

Indeed.

@vshampor vshampor closed this Oct 23, 2023
@vshampor vshampor deleted the retry_on_segfault branch January 9, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NNCF PT Pull requests that updates NNCF PyTorch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants