-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retry sanity sample runs on segfault #2112
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vshampor
force-pushed
the
retry_on_segfault
branch
from
September 6, 2023 11:44
8200f72
to
a264d46
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2112 +/- ##
===========================================
- Coverage 35.92% 35.91% -0.01%
===========================================
Files 477 476 -1
Lines 42451 42445 -6
===========================================
- Hits 15251 15245 -6
Misses 27200 27200 |
run onnx pre-commit tests |
After #2149 it can be closed? |
Indeed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
As stated in the title
Reason for changes
Working around sporadic segfaults in Torch sanity samples due to torch 2.0
Related tickets
119128
Tests
torch test_sanity_sample