Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NNCFGraph] Fix get_input_edges for parallel edges #2107

Merged
merged 5 commits into from
Sep 28, 2023
Merged

[NNCFGraph] Fix get_input_edges for parallel edges #2107

merged 5 commits into from
Sep 28, 2023

Conversation

daniil-lyakhov
Copy link
Collaborator

@daniil-lyakhov daniil-lyakhov commented Sep 5, 2023 •
edited
Loading

Changes

  • parallel_input_port_ids parameter plugged in to OVNNCFGraph
  • NNCFGraph.get_input_edges unwraps parallel_input_port_ids and returns separate entities of NNCFGraphEdge for each parallel edge

Reason for changes

  • To make possible to insert statistics collectors on parallel edges in OV backend

Related tickets

119666

Tests

  • tests/common/graph/test_nncf_graph.py is updated
  • tests/openvino/native/test_nncf_graph_builder.py is updated

@daniil-lyakhov daniil-lyakhov requested a review from a team as a code owner September 5, 2023 10:28
@github-actions github-actions bot added NNCF Common Pull request that updates NNCF Common NNCF OpenVINO Pull requests that updates NNCF OpenVINO labels Sep 5, 2023
@daniil-lyakhov
Copy link
Collaborator Author

run pytorch pre-commit tests

@daniil-lyakhov
Copy link
Collaborator Author

run tensorflow pre-commit tests

@codecov
Copy link

codecov bot commented Sep 5, 2023 •
edited
Loading

Codecov Report

Merging #2107 (f77d23b) into develop (b16d4a1) will decrease coverage by 0.12%.
The diff coverage is 64.00%.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2107      +/-   ##
===========================================
- Coverage    36.24%   36.13%   -0.12%     
===========================================
  Files          477      478       +1     
  Lines        42570    42723     +153     
===========================================
+ Hits         15428    15436       +8     
- Misses       27142    27287     +145
Files Coverage Δ
...xperimental/common/tensor_statistics/collectors.py 76.05% <ø> (ø)
nncf/common/graph/graph.py 74.11% <88.88%> (+1.33%) ⬆️
nncf/openvino/graph/nncf_graph_builder.py 0.00% <0.00%> (ø)

... and 14 files with indirect coverage changes

nikita-savelyevv
nikita-savelyevv reviewed Sep 6, 2023
View reviewed changes
nncf/common/graph/graph.py Show resolved Hide resolved
nncf/common/graph/graph.py Outdated Show resolved Hide resolved
vshampor
vshampor requested changes Sep 13, 2023
View reviewed changes
nncf/common/graph/graph.py Show resolved Hide resolved
nncf/common/graph/graph.py Outdated Show resolved Hide resolved
nncf/common/graph/graph.py Show resolved Hide resolved
nncf/common/graph/graph.py Show resolved Hide resolved
nncf/common/graph/graph.py Outdated Show resolved Hide resolved
nncf/openvino/graph/nncf_graph_builder.py Outdated Show resolved Hide resolved
tests/common/graph/test_nncf_graph.py Outdated Show resolved Hide resolved
tests/openvino/native/test_nncf_graph_builder.py Outdated Show resolved Hide resolved
@daniil-lyakhov daniil-lyakhov force-pushed the dl/fix/nncf_grpah_parallel_edges branch from d950c52 to f830e83 Compare September 26, 2023 18:22
@github-actions github-actions bot added NNCF PT Pull requests that updates NNCF PyTorch experimental labels Sep 26, 2023
@daniil-lyakhov daniil-lyakhov force-pushed the dl/fix/nncf_grpah_parallel_edges branch from f830e83 to 9eb0c50 Compare September 26, 2023 18:45
alexsu52
alexsu52 approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@alexsu52 alexsu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexsu52 alexsu52 merged commit 1920398 into openvinotoolkit:develop Sep 28, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vshampor vshampor vshampor approved these changes

@nikita-savelyevv nikita-savelyevv nikita-savelyevv approved these changes

@alexsu52 alexsu52 alexsu52 approved these changes

Assignees
No one assigned
Labels
experimental NNCF Common Pull request that updates NNCF Common NNCF OpenVINO Pull requests that updates NNCF OpenVINO NNCF PT Pull requests that updates NNCF PyTorch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@daniil-lyakhov @alexsu52 @nikita-savelyevv @vshampor