Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OV] Introduce support of quantization If operation #2101

Merged
merged 66 commits into from
Sep 25, 2023

Conversation

kshpv
Copy link
Collaborator

@kshpv kshpv commented Sep 1, 2023

Changes

Add support of quantization for OpenVINO models with If operation - https://docs.openvino.ai/2023.0/openvino_docs_ops_infrastructure_If_8.html

Reason for changes

Customer request / Obtain the maximum performance for models with inner subgraphs under If operation

Related tickets

113826

Tests

Tested on a model attached to a ticket
Add synthetic model with If operation

@github-actions github-actions bot added NNCF OpenVINO Pull requests that updates NNCF OpenVINO NNCF PTQ Pull requests that updates NNCF PTQ NNCF PT Pull requests that updates NNCF PyTorch NNCF ONNX Pull requests that updates NNCF ONNX labels Sep 1, 2023
@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Merging #2101 (36381a7) into develop (b95e71c) will decrease coverage by 0.15%.
The diff coverage is 3.72%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2101      +/-   ##
===========================================
- Coverage    36.24%   36.09%   -0.15%     
===========================================
  Files          477      478       +1     
  Lines        42570    42757     +187     
===========================================
+ Hits         15428    15432       +4     
- Misses       27142    27325     +183     
Files Changed Coverage Δ
...ncf/openvino/graph/metatypes/openvino_metatypes.py 0.00% <0.00%> (ø)
nncf/openvino/graph/model_transformer.py 0.00% <0.00%> (ø)
nncf/openvino/graph/node_utils.py 0.00% <0.00%> (ø)
nncf/openvino/graph/transformations/commands.py 0.00% <0.00%> (ø)
nncf/openvino/quantization/quantize_ifmodel.py 0.00% <0.00%> (ø)
nncf/openvino/quantization/quantize_model.py 0.00% <0.00%> (ø)
nncf/common/logging/track_progress.py 86.27% <100.00%> (-3.73%) ⬇️
nncf/quantization/algorithms/min_max/algorithm.py 95.30% <100.00%> (+0.06%) ⬆️

@vshampor vshampor added the API Public API-impacting changes label Sep 6, 2023
@github-actions github-actions bot removed NNCF PT Pull requests that updates NNCF PyTorch NNCF ONNX Pull requests that updates NNCF ONNX labels Sep 6, 2023
@kshpv kshpv marked this pull request as ready for review September 6, 2023 14:57
@kshpv kshpv requested a review from a team as a code owner September 6, 2023 14:57
@kshpv kshpv requested review from KodiaqQ and alexsu52 September 6, 2023 15:00
Copy link
Collaborator

@KodiaqQ KodiaqQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to have explanations for each method that was added. Also, the changes for the PostTrainingQuantization are not clear, including adding the backend entity for it.
The general approach and reasons for it are not clear.

@github-actions github-actions bot removed the NNCF Common Pull request that updates NNCF Common label Sep 20, 2023
@github-actions github-actions bot added the NNCF Common Pull request that updates NNCF Common label Sep 20, 2023
Copy link
Contributor

@alexsu52 alexsu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexsu52 alexsu52 merged commit def8009 into openvinotoolkit:develop Sep 25, 2023
@kshpv kshpv deleted the ov_if_op_support branch January 17, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NNCF Common Pull request that updates NNCF Common NNCF OpenVINO Pull requests that updates NNCF OpenVINO NNCF PTQ Pull requests that updates NNCF PTQ
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants