-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ruff as a linter #2031
Merged
Merged
Use ruff as a linter #2031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
Improvements or additions to documentation
NNCF TF
Pull requests that updates NNCF TensorFlow
NNCF PT
Pull requests that updates NNCF PyTorch
NNCF Common
Pull request that updates NNCF Common
experimental
NNCF OpenVINO
Pull requests that updates NNCF OpenVINO
NNCF ONNX
Pull requests that updates NNCF ONNX
NNCF PTQ
Pull requests that updates NNCF PTQ
labels
Aug 4, 2023
vshampor
added
API
Public API-impacting changes
and removed
API
Public API-impacting changes
labels
Aug 4, 2023
vshampor
force-pushed
the
ruff_fixes
branch
2 times, most recently
from
August 7, 2023 11:32
6acb790
to
189ac9e
Compare
Can you add check for copyrights like #1833? |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2031 +/- ##
===========================================
+ Coverage 36.11% 36.52% +0.41%
===========================================
Files 479 482 +3
Lines 43183 43237 +54
===========================================
+ Hits 15596 15793 +197
+ Misses 27587 27444 -143
|
vshampor
force-pushed
the
ruff_fixes
branch
2 times, most recently
from
August 18, 2023 14:22
a05b2d4
to
5873bdb
Compare
Done |
vshampor
force-pushed
the
ruff_fixes
branch
from
September 18, 2023 09:47
3b537c5
to
e8bdba2
Compare
KodiaqQ
reviewed
Sep 19, 2023
nncf/torch/pruning/filter_pruning/global_ranking/evolutionary_optimization.py
Show resolved
Hide resolved
KodiaqQ
approved these changes
Oct 11, 2023
AlexanderDokuchaev
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
API
Public API-impacting changes
documentation
Improvements or additions to documentation
experimental
NNCF Common
Pull request that updates NNCF Common
NNCF ONNX
Pull requests that updates NNCF ONNX
NNCF OpenVINO
Pull requests that updates NNCF OpenVINO
NNCF PT
Pull requests that updates NNCF PyTorch
NNCF PTQ
Pull requests that updates NNCF PTQ
NNCF TF
Pull requests that updates NNCF TensorFlow
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add ruff as a step to the
pre-commit
pipeline and adjust the codebase to conform.Reason for changes
Ruff seems to do a good job at basic linting, works much faster than pylint and doesn't even seem to need a virtual environment to function properly. We might want to replace pylint with this entirely to lessen the load on CI.
Related tickets
N/A
Tests
precommit