[Good First Issue] [NNCF] Make NNCF common tensor statistics code pass mypy checks #2493
Comments
|
Hello @vshampor, as a newcomer to open-source projects, I'm eager to get started, and I'd like to take on this particular issue. Would you please assign it to me? Thanks in advance! |
|
@vshampor I am new to the world of opensource and the concept of NNCF appears very interesting to me and I am looking forward to contribute in openvinotoolkit for GSOC'24. |
|
Thanks for being interested in this issue. It looks like this ticket is already assigned to a contributor. Please communicate with the assigned contributor to confirm the status of the issue. |
|
@vshampor and @andrei-kochin, |
|
@tvilight4 one assignee per task. You can still select any of unassigned tasks you like: https://github.com/orgs/openvinotoolkit/projects/3 |
|
@andrei-kochin Thank you for your suggestions on the issues . please do notify me about updates on any future issues related to NNCF, as it aligns with my interests. |
|
@tvilight4 I have just created #22398 for you, you may take it if you want to. |
|
@AtharvaPore01 Hi, do you have any time to finish your PR? Or we may move this issue back to the pool? |
|
@andrey-churkin Hi, Sorry for the delay from my side. I appreciate your patience. I'm currently tied up with some urgent tasks but will prioritize completing the PR as soon as possible. Your understanding is greatly appreciated. |
|
@AtharvaPore01 Sorry, but we are forced to unassign you from the issue due to a lack of activity |
|
.take |
|
Thank you for looking into this issue! Please let us know if you have any questions or require any help. |
|
@andrey-churkin I have created a PR #2865 for this issue. |
### Changes General: - Added the target code path `nncf/common/tensor_statistics` to `.mypy.ini.` - Fixed mypy errors caused by type inconsistencies. Used `# type:ignore` in the following cases: - has no attribute - incompatible types that couldn't be resolved without substantial code changes. ### Related tickets Closes Issue #2493 ### Tests To validate that the changes did not affect the codebase, some pytest tests were run. --------- Co-authored-by: Daniil Lyakhov <[email protected]>
|
@rk119 thanks for the contribution! |
This is exactly like #2495 (see the description and tasks there), but the target code path for this one is
nncf/common/tensor_statisticsinstead ofnncf/common/graph.The text was updated successfully, but these errors were encountered: