-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move image classes #538
Merged
Merged
Move image classes #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IRDonch
suggested changes
Nov 8, 2021
IRDonch
reviewed
Nov 9, 2021
IRDonch
approved these changes
Nov 10, 2021
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR moves
Image
andByteImage
classes tocomponents.media
, because these classes are parts of the domain model.uitls
are more about auxiliary things, which can be replaced by other providers.Image
andByteImage
are moved fromdatumaro.util.image
todatumaro.components.media
Image.__init__
'sloader
parameter merged intodata
, because it was not used and their semantics was overlapping.It seems that
loader
can be more clear, though.cache
parameter, because it was not used.Image
ctor's parameters are now mostly kw-onlyHow to test
Checklist
develop
branchLicense
Feel free to contact the maintainers if that's a concern.