Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax importer for Pascal VOC dataset (seach in subdirectories) #50

Merged
merged 3 commits into from
Nov 13, 2020

Conversation

nmanovic
Copy link

@nmanovic nmanovic commented Nov 11, 2020

In some cases developers don't want to specify the exact path to Pascal VOC.
Now you have to specify VOCtrainval_11-May-2012/VOCdevkit/VOC2012/. After the
patch it will be possible to specify VOCtrainval_11-May-2012/.

Summary

How to test

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

In some cases developers don't want to specify the exact path to Pascal VOC.
Now you have to specify VOCtrainval_11-May-2012/VOCdevkit/VOC2012/. After the
patch it will be possible to specify VOCtrainval_11-May-2012/.
zhiltsov-max
zhiltsov-max previously approved these changes Nov 12, 2020
Copy link
Contributor

@zhiltsov-max zhiltsov-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, however, now the structure:

a/b/c/ImageSets/Main/
a/ImageSets/Segmentation/

Is a valid dataset. But I don't think it is a real problem.

@nmanovic
Copy link
Author

Looks good, however, now the structure:

a/b/c/ImageSets/Main/
a/ImageSets/Segmentation/

Is a valid dataset. But I don't think it is a real problem.

I agree that it isn't good. I have fixed the case.

@zhiltsov-max zhiltsov-max merged commit b716103 into develop Nov 13, 2020
@nmanovic nmanovic deleted the nm/relax_voc_importer branch November 13, 2020 09:30
This was referenced Dec 10, 2020
zhiltsov-max pushed a commit that referenced this pull request Dec 11, 2020
* Relax importer for Pascal VOC dataset (search in subdirectories) (#50)

In some cases developers don't want to specify the exact path to Pascal VOC.
Now you have to specify VOCtrainval_11-May-2012/VOCdevkit/VOC2012/. After the
patch it will be possible to specify VOCtrainval_11-May-2012/.

* Allow missing supercategory in COCO annotations (#54)

Now it is possible to load coco_instances dataset even if the annotation file doesn't have supercategory

* Add CamVid format support (#55)

Co-authored-by: Maxim Zhiltsov <[email protected]>

* Fix CamVid format (#57)

* Fix ImageNet format

* Fix CamVid format

* ability to install opencv-python-headless instead opencv-python (#62)

Allow to choose `opencv=python-headless` as dependency with `DATUMARO_HEADLESS=1` env. variable when installing

* Release 0.1.4 (#63)

* update version

* update changelog

Co-authored-by: Nikita Manovich <[email protected]>
Co-authored-by: Anastasia Yasakova <[email protected]>
Co-authored-by: Andrey Zhavoronkov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants