Add patch command #401
Add patch command #401
Conversation
zhiltsov-max
force-pushed
the
zm/patch-command
branch
from
d67fe67 to
20e34e5
Compare
datumaro/plugins/transforms.py
Outdated
| dst_mask_cat = MaskCategories(attributes=src_mask_cat.attributes) | ||
| dst_mask_cat.colormap = { | ||
| id: src_mask_cat[id] | ||
| for id, _ in enumerate(src_label_cat.items) |
There was a problem hiding this comment.
| for id, _ in enumerate(src_label_cat.items) | |
| for id in range(len(src_label_cat.items)) |
| if id in src_point_cat and (self._map_id(id) or id == 0) | ||
| } | ||
| self._categories[AnnotationType.points] = dst_point_cat | ||
|
|
There was a problem hiding this comment.
IMO, there should be a check here that no categories of unknown types are present. Otherwise, if a new category type is added in the future and this class is not updated, then old label IDs could leak into the transformed dataset.
There was a problem hiding this comment.
there should be a check
Probably, a good point.
could leak
Input categories are not copied in these transforms, so no.
There was a problem hiding this comment.
Input categories are not copied in these transforms, so no.
Okay, fair point.
However, the annotations are copied. So perhaps we should make sure to only copy annotations of known types so that we can make sure that annotations aren't copied without the appropriate categories?
There was a problem hiding this comment.
Currently, addition of new annotation type is a rare event, and addition of a new categories is even more rare. I suppose, when it happen, it will require a number of similar changes across the code.
Summary
datum patchcommand, which allows to update a dataset from another datasetProjectLabelstransform to align dataset labelsLabelCategoriesby nameDataset.is_modifiedDatasetMergeError(item_idshould not be mandatory)datum diffRemapLabelsHow to test
Checklist
developbranchLicense
Feel free to contact the maintainers if that's a concern.