Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make bandit to ignore B311 for id_from_image_name transform #1657

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

jihyeonyi
Copy link
Contributor

@jihyeonyi jihyeonyi commented Oct 24, 2024

Summary

Make bandit to ignore B311 for id_from_image_name transform
--> Re-located the comment, # nosec B311)
The result of bandit-scan is pasted:

Run started:2024-10-24 06:29:43.187490

Test results:
        No issues identified.

Code scanned:
        Total lines of code: 51857
        Total lines skipped (#nosec): 6
        Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 12

Run metrics:
        Total issues (by severity):
                Undefined: 0
                Low: 0
                Medium: 0
                High: 0
        Total issues (by confidence):
                Undefined: 0
                Low: 0
                Medium: 0
                High: 0
Files skipped (0):

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2024 Intel Corporation
#
# SPDX-License-Identifier: MIT

@jihyeonyi jihyeonyi marked this pull request as ready for review October 24, 2024 06:34
@jihyeonyi jihyeonyi requested review from a team as code owners October 24, 2024 06:34
@jihyeonyi jihyeonyi requested review from itrushkin and removed request for a team October 24, 2024 06:34
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.22%. Comparing base (ff5fd94) to head (6a9d1ad).
Report is 23 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1657      +/-   ##
===========================================
+ Coverage    81.06%   81.22%   +0.16%     
===========================================
  Files          278      281       +3     
  Lines        32517    32889     +372     
  Branches      6607     5291    -1316     
===========================================
+ Hits         26360    26715     +355     
- Misses        4701     4723      +22     
+ Partials      1456     1451       -5     
Flag Coverage Δ
ubuntu-20.04_Python-3.10 81.20% <ø> (+0.15%) ⬆️
windows-2022_Python-3.10 81.20% <ø> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jihyeonyi jihyeonyi merged commit 3265766 into openvinotoolkit:develop Oct 24, 2024
9 checks passed
@jihyeonyi jihyeonyi deleted the jihyeony/ignore_b311 branch October 24, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants