Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No security check for id_from_image_name #1642

Merged

Conversation

jihyeonyi
Copy link
Contributor

@jihyeonyi jihyeonyi commented Oct 15, 2024

Summary

Ignore bandit error B311 in 'id_from_image_name' transform.

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2024 Intel Corporation
#
# SPDX-License-Identifier: MIT

@jihyeonyi jihyeonyi marked this pull request as ready for review October 15, 2024 04:13
@jihyeonyi jihyeonyi requested review from a team as code owners October 15, 2024 04:13
@jihyeonyi jihyeonyi requested review from wonjuleee and removed request for a team October 15, 2024 04:13
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.17%. Comparing base (ff5fd94) to head (8bac736).
Report is 18 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1642      +/-   ##
===========================================
+ Coverage    81.06%   81.17%   +0.10%     
===========================================
  Files          278      281       +3     
  Lines        32517    32781     +264     
  Branches      6607     5283    -1324     
===========================================
+ Hits         26360    26610     +250     
- Misses        4701     4721      +20     
+ Partials      1456     1450       -6     
Flag Coverage Δ
ubuntu-20.04_Python-3.10 81.15% <100.00%> (+0.10%) ⬆️
windows-2022_Python-3.10 81.15% <100.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wonjuleee wonjuleee merged commit 054bd95 into openvinotoolkit:develop Oct 15, 2024
9 checks passed
@jihyeonyi jihyeonyi deleted the jihyeony/fix-bandit-error branch October 16, 2024 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants