Enhance 'id_from_image_name' transform to ensure each identifier is unique #1635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1635 +/- ##
===========================================
+ Coverage 81.06% 81.17% +0.10%
===========================================
Files 278 281 +3
Lines 32517 32781 +264
Branches 6607 5294 -1313
===========================================
+ Hits 26360 26609 +249
- Misses 4701 4721 +20
+ Partials 1456 1451 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sooahleex
approved these changes
Oct 11, 2024
Comment on lines
+1213
to
+1228
| def fxt_dataset(self, n_labels=3, n_anns=5, n_items=7) -> Dataset: | ||
| video = Video("video.mp4") | ||
| video._frame_size = MagicMock(return_value=(32, 32)) | ||
| video.get_frame_data = MagicMock(return_value=np.ndarray((32, 32, 3), dtype=np.uint8)) | ||
| return Dataset.from_iterable( | ||
| [ | ||
| DatasetItem(id=1, media=Image.from_file(path="path1.jpg")), | ||
| DatasetItem(id=2, media=Image.from_file(path="path1.jpg")), | ||
| DatasetItem(id=3, media=Image.from_file(path="path1.jpg")), | ||
| DatasetItem(id=4, media=VideoFrame(video, index=30)), | ||
| DatasetItem(id=5, media=VideoFrame(video, index=30)), | ||
| DatasetItem(id=6, media=VideoFrame(video, index=60)), | ||
| DatasetItem(id=7), | ||
| DatasetItem(id=8, media=Image.from_numpy(data=np.ones([5, 5, 3]))), | ||
| ] | ||
| ) |
There was a problem hiding this comment.
Is it okay to bundle the dataset for all tests in one without dividing the dataset into several?
There was a problem hiding this comment.
As you said, we can make several datasets, but I think it doesn't matter to reuse it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket: 153389
How to test
Checklist
License
Feel free to contact the maintainers if that's a concern.